New option in settings allowing to add multiple identical effects in spellcreation #1076
Conversation
|
Is this something that should have a settings option? Seems to me it either should always or never be allowed. |
|
OpenMW before 1.0 is supposed to be replacement of vanilla engine, so I needed to make this behavior optional. That's why it's in settings. If we were already over 1.0, then I would have advocated to just remove the part of code that checks for identical effects altogether. Because its only purpose seems to be to force player to create fireballs that freeze/electrocute enemy over time... |
|
OpenMW post-1.0 is still going to be a vanilla engine replacement. It's not as if after 1.0 we're going to do anything to break Morrowind or significantly alter support beyond improving what it's capable of (playing Morrowind unmodded, OpenMW post-1.0 should mechanically be the same as 1.0). It's just a matter of encouraging people to put the effort into working on extra features (pre-1.0, people should focus on getting the missing vanilla features implemented to get to 1.0 faster, instead of taking time with new features). Given that you've already put the effort into coding it though, in my opinion the question becomes if it's a feature OpenMW wants at all and if it's good enough to put in (in particular, does it break balancing? are multiple identical effects cheaper than one effect with the same combined strength?). IMO, if it's good enough to have on by default after 1.0, it's good enough to have on by default before 1.0, given that it's already coded. If it's not good enough to have on by default after 1.0, then I don't think a settings option is the right way to go about it regardless. |
|
Spell_one:
Cost: 100, Chance: 25, Price: 787 Spell_two:
Cost: 100, Chance: 25, Price: 788 Spell_eight (max number):
Cost: 101, Chance: 24, Price: 795 Tested with Willpower=100, Destruction=50 Thankfully it doesn't break balancing at all. I have also not noticed any bugs that this would create while testing it. |
| @@ -145,6 +145,10 @@ difficulty = 0 | |||
| # Show duration of magic effect and lights in the spells window. | |||
| show effect duration = false | |||
|
|
|||
| # Do not allow to add same effect multiple times in spell creation | |||
| # Example: [fire damage 10pts for 1s]+[fire damage 1-2pts for 10s] is possible if disabled | |||
| unique spell effects = true | |||
There was a problem hiding this comment.
Well, this option must be named to be false by default. E.g. you have settings-default.cfg v0.35.0 already installed without unique spell effects in it, you download a new v0.41.0 which requires this option to be set by default to true, but there is no any... The game logic is changed. Ooops
There was a problem hiding this comment.
True - vanilla version, that does not allow multiple identical magic effects
False - version that allows multiple identical magic effects
So, that shouldn't be a problem, since it defaults to vanilla behavior. (and settings-default.cfg is replaced when updating openmw)
There was a problem hiding this comment.
Indeed. If one still has 0.35 settings-default.cfg, that means they have installed 0.41 improperly.
Also, Settings::Manager::getBool("unique spell effects", "Game") will throw, not return false, when the option is missing:
throw std::runtime_error(std::string("Trying to retrieve a non-existing setting: ") + setting
+ ".\nMake sure the settings-default.cfg file was properly installed.");
|
@kunesj do you have an active bug ticket for this issue? One needs to be created before we proceed to merge and/or close this pull request. Please post a link to that new ticket here, thanks |
|
here it is https://bugs.openmw.org/issues/3687 |
|
Thank you :) |
|
Post 1.0 feature. |
ghost
closed this
This small pull request adds option in settings to disable checking for identical effects in spell creation.
This makes it possible to for example create spells with both:
old forum thread: https://forum.openmw.org/viewtopic.php?f=2&t=3545
EDIT:
bug ticket: https://bugs.openmw.org/issues/3687